fix(ci): use GitHub refs for GCP packages instead of local links - #141
Merged
Merged
Conversation
- Remove local link overrides from pnpm-workspace.yaml - Update platform/app/package.json to use GitHub refs - Regenerate pnpm-lock.yaml with proper GitHub commit hashes This fixes CI build failures where local directories don't exist.
igoroctaviano
had a problem deploying
to
fork-pr-approval
October 4, 2026 21:07 — with 
GitHub Actions
Error
GitHub Actions
Error
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm-workspace.yamlplatform/app/package.jsonto use GitHub refspnpm-lock.yamlwith proper GitHub commit hashesProblem
CI was failing because it couldn't resolve
@idc/gcp-extensionand@idc/gcp-mode- they were configured as local links (link:../ohif-gcp-extension) which don't exist in the CI environment.Solution
Changed all references to use GitHub URLs:
github:ImagingDataCommons/ohif-gcp-extension#maingithub:ImagingDataCommons/ohif-gcp-mode#mainThe lockfile now pins to specific commit hashes for reproducible builds.