[WIP] refactor negate check - #271
Draft
mercury233 wants to merge 3 commits into
Draft
Conversation
foohyfooh
reviewed
Aug 17, 2026
foohyfooh
left a comment
foohyfooh
left a comment
Contributor
There was a problem hiding this comment.
I know this is WIP and I don't know if you planned to or not but mentioning Naturia Barkion not accounted for when Beast and Exterio are so it doesn't slip through the cracks.
| if (Enemy.Deck.Count > 2 * NATURIA_DECK_HOLD | ||
| && Enemy.HasInMonstersZone(_CardId.NaturiaBeast, true, false, true)) return true; | ||
| if (Enemy.HasInMonstersZone(_CardId.HorusTheBlackFlameDragonLV8, true, false, true)) return true; | ||
| } |
Contributor
There was a problem hiding this comment.
Shouldn't this type of check be added Naturia Barkion against Traps as well?
|
|
||
| if (isSpell) | ||
| { | ||
| if (Enemy.Deck.Count > 2 * NATURIA_DECK_HOLD |
Contributor
There was a problem hiding this comment.
I understand that Naturia Exterio would check for 2 since you don't want your next draw to be a deck out but why is this multiplied by 2 instead of +1 since you would just need one card to not deck out?
| @@ -148,7 +148,10 @@ protected class _CardId | |||
| public const int RoyalDecreel = 51452091; | |||
| public const int NaturalExterio = 99916754; | |||
| public const int NaturiaBeast = 33198837; | |||
Contributor
There was a problem hiding this comment.
Marking here for where to add Naturia Barkion regarding my comment on it negating Traps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.