update OnSelectIdleCmd - #261
Draft
mercury233 wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Adds validation and fallback handling for main-phase idle commands.
Changes:
- Adds the protocol’s shuffle action.
- Validates AI responses against available commands.
- Handles unavailable battle/end-phase transitions.
The validation is useful, but the shuffle-first fallback can repeatedly re-enter idle selection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Game/MainPhaseAction.cs |
Adds shuffle action encoding. |
Game/GameBehavior.cs |
Validates responses and selects fallbacks. |
Game/GameAI.cs |
Exposes selection clearing and improves phase fallback. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1577
to
+1589
| else if (canShuffle) | ||
| action = new MainPhaseAction(MainPhaseAction.MainAction.Shuffle); | ||
| else | ||
| { | ||
| for (int actionType = 0; actionType < actionCounts.Length; ++actionType) | ||
| { | ||
| if (actionCounts[actionType] > 0) | ||
| { | ||
| action = new MainPhaseAction((MainPhaseAction.MainAction)actionType, 0); | ||
| break; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.