Return the eigendecomposition spectrum as an unmatricized array - #223
Merged
Conversation
`eig_full`/`eigh_full` (and the `_trunc` variants) now unmatricize the spectrum `D` back to the array type, as `svd_*` already does for `S`. Previously `D` was returned as a bare matrix, inconsistent with the other factors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
- Coverage 80.05% 79.86% -0.20%
==========================================
Files 28 28
Lines 1038 1038
==========================================
- Hits 831 829 -2
- Misses 207 209 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eig_full/eigh_full(and the_truncvariants) now unmatricize the spectrumDback to the array type, assvd_*already does forS. PreviouslyDwas returned as a bare matrix, inconsistent with the other factors.