split table terms of use and access - #12659
Draft
jo-pol wants to merge 2 commits into
Draft
Conversation
of DANS-KNAW#251 at 972a501 (irrelevant import changes)
14 tasks
jo-pol
marked this pull request as draft
August 31, 2026 09:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR prepares the Dataverse codebase for file-specific licenses/terms by splitting the legacy model “TermsOfUseAndAccess” into two separate models (“TermsOfUseOrLicense” and “TermsOfAccess”) and updating persistence, API, UI, and tests accordingly.
Changes:
termsofaccessandtermsofuseorlicensetables (Flyway) and updates entity mappings and references.Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
See my cheat sheet for a DANS VM of v6.11 https://github.com/DANS-KNAW-jp/dataverse/blob/DD-2318-spilt-termsOUAA/tests/shell/DANS-v6-10/restrict-file.sh
These test clearly did not cover code flagged by Codepilot DANS-KNAW-jp@cf45fb2
between v6.10 and v6.13 new classes are introduced using the old TermsOfUseAndAccess. We have no means to test the changes.
Should I still have missed something: null pointer exceptions usually meant an omission in pairs of lines like
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Yes, a DB table is split into two tables and its references needs updates, so:
Additional documentation: