[ILIAS 11] [FIX] TestQuestionPool: Translate plugin question types#11643
Open
Saaweel wants to merge 1 commit into
Open
[ILIAS 11] [FIX] TestQuestionPool: Translate plugin question types#11643Saaweel wants to merge 1 commit into
Saaweel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Plugin question type is not translated in question pool
Mantis: #0047758
Problem
The question list in a question pool was not translating the type name of plugin questions. The
ilAssQuestionList::loadfunction was calling$this->lng->txt($row['question_type'])directly, bypassing the plugin's own translation mechanism. The same issue existed inassQuestionGUI::outQuestionType(), used byilTestCorrectionsGUI::populatePageTitleAndDescription.Solution
Added a
getQuestionTypeTranslation()helper method in bothilAssQuestionListandassQuestionGUIthat checks whether the question belongs to a plugin and, if so, delegates to$plugin->getQuestionTypeTranslation(). Otherwise it falls back to the standard language translation.Files changed
components/ILIAS/TestQuestionPool/classes/class.ilAssQuestionList.phpcomponents/ILIAS/TestQuestionPool/classes/class.assQuestionGUI.phpHow to test
ilTestCorrectionsGUI).