[FIX] Auth/SOAP: Make SOAP authentication work again#11635
Open
mjansenDatabay wants to merge 1 commit into
Open
[FIX] Auth/SOAP: Make SOAP authentication work again#11635mjansenDatabay wants to merge 1 commit into
mjansenDatabay wants to merge 1 commit into
Conversation
thojou
requested changes
Jun 2, 2026
Contributor
thojou
left a comment
There was a problem hiding this comment.
Hey @mjansenDatabay,
Thanks for the PR! Aside from the minor docblock type suggestions, I noticed a naming inconsistency: the component directory is components/ILIAS/SOAPAuth, but its namespace is declared as ILIAS\AuthSOAP.
Could we align these to follow a consistent convention? Let me know what you think.
Kind Regrads,
@thojou
Contributor
Author
Hi @thojou , I decided to use
Best regards, |
6e00290 to
5558f91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Triggered by the issue described in https://mantis.ilias.de/view.php?id=47821 , I had a closer look at the "SOAP Authentication" in ILIAS >= 10.x, which seemed broken because of fragile PHP code in the
nusoap_clientlibrary.SOAPAuthcomponent structure to align with ILIAS 10 conventions: public demo endpoints are now exposed viapublic/auth/soap/example/..., classes are insrc/, and namespaced underILIAS\AuthSOAP.SessionValidationClient,SessionValidationResult,SoapAuthEndpoint) to encapsulate endpoint building, SOAP request execution, and typed result handling.nusoap_clientto native PHPSoapClientwhile preserving wire compatibility (RPC/encoded mode, .NET-specific parameter names/soapaction handling).SoapServerhandles POST SOAP calls; nusoap remains for WSDL/non-POST handling to keep compatibility.soap_auth_use_dotnet(instead of mixed/incorrect key usage).If approved, this has to be picked/ported to
release_11andtrunk.