Add all accepted ILIAS 12 NPM dependency PRs into package.json#11262
Conversation
There was a problem hiding this comment.
Hi @lscharmer,
Thx a lot for providing the integration of the dependency PR's and for your detailed summary. Much appreciated.
-
chart.js: @tfamula requested this last time (#8646), maybe @schmitz-ilias or @alex40724 can take over on behalf of Leifos? This would be much appreciated, I am not very familiar with the library in question, but we ultimately need it for the charts inside UI framework. -
jstree: @alex40724 requested this last time (#10215), maybe he could do so again. But sine this is legacy UI, it could also be shepherded by someone else. -
eslint-config-airbnb-base: this is my mistake, I should have requestedeslintwith v8. Since having no code-style is so much worse than using a deprecated development dependency, I would ask you to downgradeeslintand incorporate theeslint-config-airbnb-basepackage again. I also requested the same procedure last time, which got approved by JF (#9840). -
rollup: works on my machine (macOS 26.3.1) – I think we're good this time =). Thx for inspecting.
Other code changes to the UI framework LGTM. Funny that this test case worked before?
Kind regards,
@thibsy
|
@ILIAS-eLearning/technical-board let me know if I should go to JF with this again. |
@thibsy: There is no need to go through the JF again, the dependency is accepted. |
c4d1680 to
f9deaa1
Compare
|
This PR is still missing 2 dependencies to be complete.
Best regards |
f9deaa1 to
bdefa0b
Compare
|
Hi @ILIAS-eLearning/technical-board, Additionally all dependency versions are now prefixed with I also run npm audit (for chat as well) to fix all security issues (the major version of This PR can IMO be merged now. |
Hi,
this PR merges all accepted ILIAS 12 NPM dependencies.
The following PRs are included:
For root
package.json:@yaireo/tagifyas npm Dependency for ILIAS 12 #10663dropzoneas npm Dependency for ILIAS 12 #10664@rollup/plugin-node-resolveas npm Dependency for ILIAS 12 #10665@rollup/plugin-terseras npm Dependency for ILIAS 12 #10666eslintas npm Dependency for ILIAS 12 #10667eslint-config-airbnb-baseas npm Dependency for ILIAS 12 #10668eslint-plugin-importas npm Dependency for ILIAS 12 #10669jsdomas npm Dependency for ILIAS 12 #10670rollupas npm Dependency for ILIAS 12 #10671sassas npm Dependency for ILIAS 12 #10672webui-popoverfor ILIAS 12 #10633mathjaxfor ILIAS 12 #10624linkifyjsandlinkify-elementfor ILIAS 12 #10569jqueryfor ILIAS 12 #10567For
components/ILIAS/Chatroom/chat/package.json:winston#10566uuid#10565socket.ioandsocket.io-client#10564mariadb#10563express#10559Things to note
eslint+eslint-config-airbnb-baseThis is the same issue as mentioned in: #9086The package
eslint-config-airbnb-baserequires an out of date version ofeslint(https://eslint.org/version-support/).I opt for dropping it for now.eslintis now downgraded to v8, which resolves this issue.rollupon MacAs mentioned & fixed by @thibsy in #9361, some packages (e.g. for mac) where not included with the normal
npm installto create thepackage-lock.json.Even though I created the
package-lock.jsonthe same way as last year, this time the packages are already included AFAIK:vs.
package-lock.jsonbefore PR #9361:$ grep rollup-darwin package-lock.json "@rollup/rollup-darwin-arm64": "4.38.0", "@rollup/rollup-darwin-x64": "4.38.0",@thibsy it would be great if you could verify this, I will test this too as soon as I have a Mac available.
Fixing Unit Tests
The change made in:
components/ILIAS/UI/tests/Client/Table/Presentation/presentation.table.test.jsfixes an endless loop error. With this change all JS Unit Tests run successfully.Summary
In comparison to ILIAS 11:
New dependencies: None
Removed dependency: