ci: stop Node 26 from failing workflow#2105
Merged
Merged
Conversation
8e39bb4 to
28a6907
Compare
veronika-alraheem
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Add
continue-on-error: truefor Node 26 matrix job to prevent failing the entire workflowPR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
Node 26 is not yet LTS but we test it as part of the matrix to get ahead of any issues.
It is not a required check, but if the job fails it causes the entire test workflow to fail, blocking merges.
What is the new behavior?
Add
continue-on-errorflag to the test job and get a value from${{ matrix.node == '26' }}so it istruefor Node 26 (i.e. the workflow can continue even if Node 26 fails).It evaluates to
falsefor Node 22 and 24 preserving the existing behaviour since we need both those checks to pass we can shortcut and stop work if one of them fails.Does this PR introduce a breaking change?
Other information