Remove reflection from provider instantiation in tests - #1770
Open
michael-ma-dev wants to merge 1 commit into
Open
Remove reflection from provider instantiation in tests#1770michael-ma-dev wants to merge 1 commit into
michael-ma-dev wants to merge 1 commit into
Conversation
Multiple places use reflection to create providers unnecessarily. Replace `Class.forName(...).getDeclaredConstructor().newInstance()` with direct constructors for `OpenJCEPlus`, `OpenJCEPlusFIPS`, and `BouncyCastleProvider`. Fixes: IBM#1709 Signed-off-by: Michael Ma <michael.ma@ibm.com>
michael-ma-dev
marked this pull request as ready for review
September 10, 2026 18:36
michael-ma-dev
requested review from
KostasTsiounis,
jasonkatonica,
johnpeck-us-ibm and
taoliult
September 10, 2026 18:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple places use reflection to create providers unnecessarily.
Replace
Class.forName(...).getDeclaredConstructor().newInstance()with direct constructors forOpenJCEPlus,OpenJCEPlusFIPS, andBouncyCastleProvider.Fixes: #1709
Signed-off-by: Michael Ma michael.ma@ibm.com