Update KeyAgreement classes to support Generic secret generation - #1753
Open
JinhangZhang wants to merge 1 commit into
Open
Update KeyAgreement classes to support Generic secret generation#1753JinhangZhang wants to merge 1 commit into
JinhangZhang wants to merge 1 commit into
Conversation
JinhangZhang
requested review from
KostasTsiounis,
jasonkatonica and
johnpeck-us-ibm
September 1, 2026 13:57
johnpeck-us-ibm
requested changes
Sep 3, 2026
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright IBM Corp. 2023, 2024 | |||
| * Copyright IBM Corp. 2023, 2025 | |||
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright IBM Corp. 2023, 2024 | |||
| * Copyright IBM Corp. 2023, 2025 | |||
| /* | ||
| * Copyright IBM Corp. 2023, 2024 | ||
| * Copyright IBM Corp. 2023, 2025 | ||
| * |
KostasTsiounis
requested changes
Sep 3, 2026
| } | ||
| } | ||
|
|
||
| public void test_engineGenerateSecret() throws Exception { |
Member
There was a problem hiding this comment.
Doesn't this need to be annotated with @Test?
The engineGenerateSecret(String) method in KeyAgreement classes currently only supports "TlsPremasterSecret", but the expectation starting in Java 25 is that "Generic" should be accepted as well. This change accomplishes that. Additional test cases to verify said behaviour are added. Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
JinhangZhang
force-pushed
the
openjceplus/backport/java17/genericsecretgeneration
branch
from
September 3, 2026 20:30
8383b7c to
22587e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engineGenerateSecret(String) method in KeyAgreement
classes currently only supports "TlsPremasterSecret",
but the expectation starting in Java 21 is that
"Generic" should be accepted as well. This change
accomplishes that.
Additional test cases to verify said behaviour are
added.
Back-ported from: #573