Convert Diffie-Hellman Key tests to JUnit 5 parameterized tests - #1745
Open
Mohit-Rajbhar100698 wants to merge 1 commit into
Open
Convert Diffie-Hellman Key tests to JUnit 5 parameterized tests#1745Mohit-Rajbhar100698 wants to merge 1 commit into
Mohit-Rajbhar100698 wants to merge 1 commit into
Conversation
This update convert the existing Diffie-Hellman Key tests into Junit5 parameterized test classes. Changes: - Move BaseTestDH to the ibm.jceplus.junit.tests package as an abstract base test class. - Add two classes extending BaseTestDH. One class is used to run tests with the OpenJCEPlus and OpenJCEPlusFIPS providers, and the second concrete class is used to run the multithreaded tests. - Convert BaseTestDHInterop.java to the parameterized test class TestDHInteropSunJCE.java. - Convert BaseTestDHKeyFactory.java to the parameterized test class TestDHKeyFactory.java. - Convert BaseTestDHKeyPairGenerator.java to the parameterized test class TestDHKeyPairGenerator.java. - Convert BaseTestDHMultiParty.java to the parameterized test class TestDHMultiParty.java. - Remove references to the deleted test classes from openjceplus/TestAll.java and openjceplusfips/TestAll.java. - Remove references to the deleted multithreaded test class from junit/TestMultithread.java and junit/TestMultithreadFIPS.java. Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>
Mohit-Rajbhar100698
requested review from
KostasTsiounis,
jasonkatonica and
johnpeck-us-ibm
August 27, 2026 06:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update convert the existing Diffie-Hellman Key tests into Junit5 parameterized test classes.
Changes:
Signed-off-by: Mohit Rajbhar mohit.rajbhar@ibm.com