Remove static from test variables - #1723
Open
Mohit-Rajbhar100698 wants to merge 1 commit into
Open
Conversation
Mohit-Rajbhar100698
force-pushed
the
fix/remove-static-variable
branch
3 times, most recently
from
August 21, 2026 04:57
1398f49 to
5a625c1
Compare
Mohit-Rajbhar100698
changed the title
Mohit-Rajbhar100698
requested review from
KostasTsiounis,
jasonkatonica and
johnpeck-us-ibm
August 26, 2026 07:02
johnpeck-us-ibm
requested changes
Aug 28, 2026
Mohit-Rajbhar100698
force-pushed
the
fix/remove-static-variable
branch
from
August 28, 2026 16:04
5a625c1 to
c5274c2
Compare
|
|
||
| // This CCM TAG LENGTH is specified in bits. Valid values are: 32, 48, 64, 60, 96, 112, and 128 | ||
| // Although initialized here, the ccmTagLength will actually be selected randomly for each iteration. | ||
| public static int ccmTagLength = 128; |
Collaborator
Author
There was a problem hiding this comment.
This seems to be a dead variable . There is no any references to this variable.
Should I remove it ?
Member
There was a problem hiding this comment.
Yes. If not referenced please remove it.
Collaborator
Author
There was a problem hiding this comment.
Removed
Mohit-Rajbhar100698
force-pushed
the
fix/remove-static-variable
branch
from
August 31, 2026 06:38
c5274c2 to
9760761
Compare
Remove the static modifier from the test variables to ensure each instance maintains its own state and to support future multithreaded test execution and remove unreferenced variable. Changes: - In src/test/java/ibm/jceplus/junit/tests/TestAESCCM.java file. - In src/test/java/ibm/jceplus/junit/tests/TestAESCCM2.java file. Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>
Mohit-Rajbhar100698
force-pushed
the
fix/remove-static-variable
branch
from
August 31, 2026 07:58
9760761 to
d015ee4
Compare
johnpeck-us-ibm
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the static modifier from the test variables to ensure each instance maintains its own state and to support future multithreaded test execution.
Changes:
Signed-off-by: Mohit Rajbhar mohit.rajbhar@ibm.com