fix: default null TokenScannerSymbols to DefaultTokenScannerSymbols#1328
Merged
jasmith-hs merged 1 commit intoJul 24, 2026
Merged
Conversation
Tokens constructed with a null TokenScannerSymbols caused getSymbols() to return null, leading to NPEs in Token.parse() and TagNode.reconstructEnd(). Default a null value to DefaultTokenScannerSymbols in the Token base constructor so callers passing null remain backwards compatible. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jasmith-hs
marked this pull request as ready for review
July 23, 2026 21:17
mnobile-hs
approved these changes
Jul 23, 2026
jasmith-hs
deleted the
jasmith_hubspot/tagnode-default-scanner-symbols-2.8.x
branch
July 24, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport to
master-2.8.x.Token(and thereforeTagNodeviamaster.getSymbols()) treats itsTokenScannerSymbolsas required. When aTokenis constructed with anullTokenScannerSymbols,getSymbols()returnsnull, which leads toNullPointerExceptions inToken.parse()andTagNode.reconstructEnd().This restores backwards compatibility for callers (e.g. downstream code that builds tokens/
TagNodes directly and previously relied on default symbols) by defaulting anullTokenScannerSymbolstoDefaultTokenScannerSymbolsin theTokenbase constructor. This is the single point that feeds everygetSymbols()call andparse(), so allNode/Tokensymbol access becomes null-safe.Testing
TagTokenTest.itDefaultsNullSymbolsToDefaultTokenScannerSymbols, verifying aTagTokenbuilt withnullsymbols resolves toDefaultTokenScannerSymbolsand parses correctly.mvn -Dtest=TagTokenTest testpasses (5/5).This PR description was authored by Claude Code.