Skip to content

style: keep control statement bodies on indented lines - #5

Merged
Htkym merged 3 commits into
mainfrom
feature/format-control-statements-20261031
Oct 31, 2026
Merged

Htkym merged 3 commits into
mainfrom
feature/format-control-statements-20261031

Conversation

@Htkym

@Htkym Htkym commented Oct 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • Format repository-owned TypeScript with Prettier, then enforce next-line control bodies, two-space indentation, and no trailing spaces with ESLint Stylistic.
  • Keep separate statements and else visually distinct. No product logic or release-version changes.
  • Add a read-only canonical-pipeline check to Windows CI. Track TypeScript as LF to keep Windows and Linux results consistent.

Verification

  • Final head 62601274b0b574e4f2214260b179b263385a3632: Windows CI passed, including format check, TypeScript check, package build, and existing VSIX allowlist/hash/metadata verification.
  • Normalized TypeScript AST is identical in all 12 source files. String, regex, template, and comment tokens remain unchanged. Punctuation-only changes: 21 semicolons, 88 added parenthesis pairs / 1 removed pair, and 6 leading union-type bars.
  • Repeating the complete formatting pipeline produces identical source hashes. A negative test rejects the old ambiguous same-line statement layout.
  • Existing dependency versions are unchanged; 5 formatting dev dependencies and 117 lockfile nodes are added. Formatting tools are excluded from the VSIX payload.

Unresolved dependency warning

npm audit reports 10 affected packages (8 moderate, 2 high), compared with 5 (3 moderate, 2 high) on the unchanged baseline lockfile. The increase is propagation of the existing minimatch glob-amplification DoS advisory (GHSA-g3hv-75wg-m249) to 5 new dev-tool dependency parents, not a new high-severity advisory. Formatting uses fixed repository glob patterns and these tools are not shipped in the VSIX. No unsafe major-version override, downgrade, or unrelated audit fix is included; the warning remains unresolved.

No release is needed for this formatting-only change.

@Htkym
Htkym merged commit 3226ee0 into main Oct 31, 2026
2 checks passed
@Htkym
Htkym deleted the feature/format-control-statements-20261031 branch October 31, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant