Share one continuation core between the AbsLog{2} workers - #47
Merged
Conversation
`_symcover_min_abslog2` and `_cover_min_abslog2` now gather a `SupportSystem` and call `_abslog2_continuation`, which holds the single copy of the objective, the dense/Woodbury/LSQR solves, the line search and the stage loop. Each support entry is stored once; an off-diagonal symmetric edge carries multiplicity 2, and assembly adds row q only when q ≠ p, which reproduces the previous systems exactly. Dense and Woodbury results and iteration counts are unchanged; the symmetric LSQR operator has half the rows and differs at rounding level. Symmetric solves are ~30% faster. Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 97.87% 98.26% +0.39%
==========================================
Files 13 13
Lines 2964 2712 -252
==========================================
- Hits 2901 2665 -236
+ Misses 63 47 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_symcover_min_abslog2and_cover_min_abslog2now gather aSupportSystemand call_abslog2_continuation, which holds the single copy of the objective, the dense/Woodbury/LSQR solves, the line search and the stage loop. Each support entry is stored once; an off-diagonal symmetric edge carries multiplicity 2, and assembly adds row q only when q ≠ p, which reproduces the previous systems exactly. Dense and Woodbury results and iteration counts are unchanged; the symmetric LSQR operator has half the rows and differs at rounding level. Symmetric solves are ~30% faster.Assisted-by: Claude Fable 5 noreply@anthropic.com