Run narrow-precision MMC solves in Float64 - #46
Merged
Merged
Conversation
The AbsLog{2} penalty continuation resolves descent of order eps(T) at
penalty strengths up to 1e8, and its tolerances are multiples of eps(T).
Both assume double precision: in Float32 every stage past the first makes
no progress. A working type narrower than Float64 now runs the whole
solve in Float64, on the matrix `convert`ed in place of its wrapper, and
returns the cover in the element type the input calls for.
Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Assisted-by: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 98.41% 97.87% -0.54%
==========================================
Files 13 13
Lines 2958 2964 +6
==========================================
- Hits 2911 2901 -10
- Misses 47 63 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AbsLog{2} penalty continuation resolves descent of order eps(T) at penalty strengths up to 1e8, and its tolerances are multiples of eps(T). Both assume double precision: in Float32 every stage past the first makes no progress. A working type narrower than Float64 now runs the whole solve in Float64, on the matrix
converted in place of its wrapper, and returns the cover in the element type the input calls for.