fix(ui): make Terminology navigation configuration-aware - #620
Open
Gordex2014 wants to merge 2 commits into
Open
fix(ui): make Terminology navigation configuration-aware#620Gordex2014 wants to merge 2 commits into
Gordex2014 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
HFS_TERMINOLOGY_SERVER.noopener,noreferrer, and htmx boosting disabled./ui/terminologyfor missing and invalid configuration states.Configuration behavior
HFS_TERMINOLOGY_SERVER/ui/terminologyand explains the URL requirements./ui/terminologyand shows how to configure the variable.A valid destination must be an absolute HTTP or HTTPS URL with a host. Paths and a trailing slash are allowed. Credentials, query strings, fragments, surrounding whitespace, and other schemes are rejected for navigation.
Invalid values never reach an
hrefor appear in the rendered page.Accessibility and progressive enhancement
Both navigation paths use native anchors, so they remain focusable and keyboard-activatable without JavaScript.
The external link:
target="_blank"andrel="noopener noreferrer".hx-boost="false"to preserve native browser navigation.Scope
This change does not add a terminology browser or administrative console. That work remains tracked by #551.
It does not change how search, validation, FHIRPath, or editor pickers consume the configured terminology server.
Verification
cargo fmt --all -- --checkcargo test -p helios-ui --test router_http terminology_navigation_reflects_the_configurationcargo test -p helios-ui catalogs_share_the_same_key_setcargo clippy -p helios-ui --all-targets --no-deps -- -A clippy::question_mark -D warningsCloses #611