feat(subscriptions,ui): delivery instrumentation — 24-hour counts and first-try success rate - #588
Merged
Merged
Conversation
… first-try rate The engine gains the missing half of #580 (#586): a rolling ring of 48 half-hour, epoch-aligned buckets per subscription — the same shape as the dashboard's day window — bumped at the single dispatch funnel every channel already runs through. Success records whether it landed on the first attempt; permanent errors and exhausted retries record as failures. In-memory by design: the window resets with the process like the rest of the engine's state, and the module says so. The operator page fills in what shipped absent: the fourth card becomes DELIVERED IN 24 H with the first-try rate as its qualifier (absent when nothing was delivered — never a fabricated 100%), and the table gains the design's LAST 24 HRS column. Strings in en/es/de. Verified live: five Encounters through two delivering channels put 10 on the card with the rate rendered, read back through the provider from the real dispatch path.
smunini
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #586 — the second half of #580's operator page.
Stacked on #585 (base
feat/580-subscriptions-ui): GitHub retargets tomainwhen it merges, activating the Development link; the diff shrinks to just this feature then.What the engine gains
A rolling ring of delivery counters per subscription (
delivery_stats.rs): 48 half-hour, epoch-aligned buckets — deliberately the same shape as the dashboard'sDashboardWindow::LastDay, so both surfaces bucket time identically. Outcomes are recorded at the single dispatch funnel every channel already runs through (dispatch_with_retry): success carries whether it landed on the first attempt; permanent errors, exhausted retries, and dispatch errors record as failures. Cost per delivery: one mutex-guarded bump.In-memory by design. The window resets with the process, like the rest of the engine's volatile state, and the module docs say so. A durable delivery log (queryable across restarts) is separate, storage-backed work — deliberately out of scope.
What the page fills in
Verification