style(fhir-validator): satisfy rustfmt in the editor tests (unbreak main) - #587
Merged
Conversation
Three `set_value` calls in the `#[cfg(test)]` module exceed rustfmt's default fn_call_width (60) and were left on one line, so `cargo fmt --all -- --check` fails. This has been breaking main's Linting job since 9636888 (#573), which takes every branch cut from main red with it. Whitespace only, confined to tests; no behavior change. Claude-Session: https://claude.ai/code/session_0197k7pHRnRPd2TaDjibNSDJ
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis currently red. The Linting job fails at its first step,cargo fmt --all -- --check, and has since 9636888 (the #573 merge) — see run 32282460213.Because formatting is the first step, clippy never runs on main right now, and every branch cut from main inherits the failure. #585 hit exactly this.
The cause
Three
set_valuecalls ineditor.rs's#[cfg(test)]module sit just over rustfmt's defaultfn_call_widthof 60, so rustfmt wants them exploded one-argument-per-line and--checkfails on the difference:The change
rustfmtapplied to that file, nothing else. Whitespace only, entirely inside the test module — no behavior change.Verification
cargo fmt --all -- --check— clean across the workspacecargo test -p helios-fhir-validator --all-features— all pass, 0 failuresNote the same three hunks are also in #585, which had to carry the fix to get its own Linting job past this step. Whichever lands first, the other side resolves as an identical no-op.