Repository navigation
fix(lint): flag absolute links only to the Interbox docs space - #1
Merged
Merged
Conversation
docs-tools' absolute-links check defaults to www.health-samurai.io/docs, which covers every product's docs on that domain. Links from Interbox pages to Aidbox's docs (ops/sizing.md, synced from interbox v1.23.1) were reported as links to our own site and failed lint, which also blocked the update job's push through the pre-push hook. Scope the check to www.health-samurai.io/docs/interbox. Links to other Interbox pages are still caught; links to other products' docs, which cannot be relative, are allowed. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
docsworkflow failed onmainafter the v1.23.1 sync (run 38396135259). It failed in two places:ops/sizing.md:110and:123. Both lines link to Aidbox's own docs: its PostgreSQL extensions page and its managed PostgreSQL guide.Push changesstep was refused, because the pre-push hook runs the same lint.docs-tools'
absolute-linkscheck defaults todocs.aidbox.appandwww.health-samurai.io/docs. The second domain covers every product's docs, so any link from these pages to another product's docs counts as a link to this site. Those links cannot be relative.This PR sets the check's
domainsindocs-lint.yamltowww.health-samurai.io/docs/interbox. Absolute links to Interbox's own pages still fail. Links to Aidbox or other products' docs are allowed.Test plan
bun linton currentmaincontent with this config: exit 0, Absolute Links reports no issueshttps://www.health-samurai.io/docs/interbox/ops/deployadded temporarily: still reported as an error, then removeddocsworkflow lint passes on this PRupdatejob's push succeeds🤖 Generated with Claude Code