Repository navigation
Conversation
…ve Muse leg The pin pointed at e856f77, a pre-squash commit from a harper PR branch that never landed on main. It predates harper d2cb72a658, which taught the footer grammar the native `muse` leg and Gemini authors, so every footer the current pre-push helper writes with `muse` counted 0 reviews and failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Dispatch-Task: pr-maint-2b964fca1b68d933fd0647c5cf664df4
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
Release cherry-pick
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⊙ Problem
The
review-coveragecheck fails on PRs whoseReview-Coverage:footer lists the nativemusereview, even though the current pre-push helper writes that footer. Example: Replication certifies origin floors for subscription checkpoints.The workflow pins the action to
e856f77. That commit is a pre-squash commit from a harper PR branch and is not on harpermain. It predates harperd2cb72a658, which addedmuseand Gemini authors to the footer grammar.🤔 Is the requirement right?
Yes. The check should accept every footer the helper writes. This workflow runs on
pull_request_target, so the fix has to land onmain; a PR branch cannot change it.💡 Solution
Pin the action to the current harper
maintip: thereview-coverageaction pin now namesea43e567. The# maincomment already namesmainas the tracked ref.✅ Verification
I ran both action versions locally against the live body of every open harper-pro PR (21 PRs) in
enforcemode:muse).framing_paths,pr_author_association) default to empty, so this workflow'swith:block needs no change.🤖 Generated by Claude Opus 5.5; posted via @kriszyp.
Release target: v5.3 — v5.3 carries the same pin (from #947), so PRs into v5.3 fail the same way
Related PRs: none found
Complexity: easy
Review-Coverage: authored=claude; ran=gemini,codex,cursor-composer; adjudicated=domain; blocked=muse(failed); declined=cursor-grok,cursor-kimi,cursor-muse; rounds=1; full=1 @ 673de3e
Review-Attention: skim ~2m (raised: degraded review) @ 673de3e