Repository navigation
Document that source maps are off by default in 5.4, and how to turn them on #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kriszyp
wants to merge
7
commits into
main
Choose a base branch
from
kris/source-maps-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
β1
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
075b18d
Document that source maps are off by default and how to enable them
kriszyp a3b1a64
Mark the source-map default as changed in 5.4, cover component sourceβ¦
kriszyp 9381eff
Scope the source-map note to modules Node.js loads itself
kriszyp 4939063
Name the unmapped VM loaders and drop the bare node-flag hint
kriszyp eb7389c
Lead the source-map section with how to enable them, and say what Fabβ¦
kriszyp 1aa381a
Count natively loaded packages in the source-map scope, drop the lineβ¦
kriszyp 5d79e30
Scope the Fabric limit to clusters Harper hosts, and drop the every-tβ¦
kriszyp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If most people are running Harper on Fabric, how do they enable it? NODE_OPTIONS is not a great example for that use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. On Fabric clusters that Harper hosts there is no way to turn them on today:
NODE_OPTIONS: users don't control the process environment, and I found no Fabric control (central-manager, host-manager, studio) that sets it.threads.v8Flags:--enable-source-mapsis a Node.js flag, not a V8 flag, so it can't be passed this way.What this costs a Fabric user is smaller than it looks. Application code on the default
vm-current-contextloader was never source-mapped. Harper strips TypeScript types there without moving code, so those stack traces are unchanged. What stays unmapped is frames from Harper's core and from npm packages Harper loads natively. The section now says this (debugging.md), and the release note limitsNODE_OPTIONSto environments you control.If we want Fabric users to have a way in, a small core change would do it: a Harper config key that makes the main thread call
process.setSourceMapsEnabled(true)at startup. Workers already inherit that (manageThreads.jspasses--enable-source-mapswheneverprocess.sourceMapsEnabledis true). I left this thread open in case you'd like that before this merges, or know of a Fabric env-var control I missed.β Claude Opus 5.5