Repository navigation
Conversation
#402 raised e2e-ready's Kueue wait for the same reason but missed cert-generator, which installs Kueue in every compose stack. In #407's frontend shard the 120 s wait timed out at 00:55:02, set -e stopped setup-k8s.sh before it created the ResourceFlavor, ClusterQueue and LocalQueue, and the stack came up anyway because the entrypoint runs setup-certs.sh after a ';'. Every executor pod was then refused: failed calling webhook mpod.kb.io, no endpoints available for service kueue-webhook-service.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
area: deploy
|
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #402, which raised e2e-ready's wait for Kueue's controller from 120 s to 300 s but missed cert-generator, the compose service that installs Kueue in every stack. In #407's frontend shard, cert-generator's own 120 s wait timed out at 00:55:02.
set -ethen stoppedsetup-k8s.shbefore it created the ResourceFlavor, ClusterQueue and LocalQueue. The stack came up anyway, since the entrypoint runssetup-certs.shafter a;(deliberate since #184). From then on every executor pod was refused: "failed calling webhook mpod.kb.io ... no endpoints available for service kueue-webhook-service".Changes
setup-k8s.shwaits up to 300 s fordeployment/kueue-controller-manager, with the same one-line reason as #402: Kueue's cert bootstrap answers/readyzwith 404 until the kubelet mounts its new secret.Warning
In production Kueue is usually installed already, so this wait returns at once. On an empty cluster (the yearly k3s certificate reset), a slow Kueue start can now outlast the deploy's
docker compose up --wait --wait-timeout 180and fail the deploy loudly, where today it comes up without the queues.Type of Change
Test Plan
cd backend && uv run pytest tests/unit)cd frontend && npm run test)docker compose exec -T backend sh -c 'uv sync --group test --no-dev --frozen --no-install-project --no-build && pytest tests/e2e')cd frontend && npm run test:e2e)./deploy.sh openapi, then./deploy.sh types), never edited by handValidation: a one-value change; both E2E jobs on this PR run cert-generator with it.
Checklist
pre-commit run --all-filesand all checks passSummary by cubic
Fixes cert-generator's wait for Kueue's controller-manager so its ResourceFlavor, ClusterQueue, and LocalQueue get created on slow starts. Follow-up to #402, which raised the same wait in e2e-ready but missed cert-generator.
setup-k8s.shnow waits up to 300s instead of 120s. The shorter timeout could expire while Kueue's cert bootstrap answers/readyzwith 404 until the kubelet mounts its new secret;set -ethen stopped the script before creating the queues, leaving every executor pod refused with no endpoints forkueue-webhook-service. On clusters where Kueue is already installed the wait returns immediately; on a slow fresh start it may outlast the deploy'sdocker compose up --wait --wait-timeout 180and fail loudly instead of coming up without the queues.Written for commit a2ccad6. Summary will update on new commits.