Skip to content

Mohammed A - #7

Open
mohammedalfakih-dev wants to merge 2 commits into
HackYourAssignment:mainfrom
mohammedalfakih-dev:week9/mohammed-alfakih
Open

Mohammed A#7
mohammedalfakih-dev wants to merge 2 commits into
HackYourAssignment:mainfrom
mohammedalfakih-dev:week9/mohammed-alfakih

Conversation

@mohammedalfakih-dev

Copy link
Copy Markdown

Summary

Completed the Week 9 NYC Taxi analytics assignment.

Changes

  • Added validation queries for duplicates, nulls, fare ranges, and orphaned pickup zones.
  • Created vw_fact_trips and vw_dim_zones.
  • Added verification queries for volume, revenue, geospatial, and time patterns.
  • Added data_dictionary.md, AI_ASSIST.md, and the borough-count screenshot.

Comment thread verification_results.sql Outdated
FROM vw_fact_trips AS t
GROUP BY
TO_CHAR(t.pickup_datetime, 'Day'),
EXTRACT(DOW FROM t.pickup_datetime)

@danlaudk danlaudk Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is dangerous doign group by two things when you only want one , even though you hope/expect the same thing. maybe you can still put both in the select, and if not there must be a cleaner alternative (even to use FIRST would be better)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I updated the query to group only by the weekday number and use a representative date to display the weekday name.

@github-actions

Copy link
Copy Markdown

📝 HackYourFuture auto grade

Assignment Score: 95 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 60
🧪 The auto grade is experimental and still being improved

Test Details

=== Week 9 Autograder ===
  ✓ PASS  found validation_queries.sql
  ✓ PASS  found schema_setup.sql
  ✓ PASS  found data_dictionary.md
  ✓ PASS  found verification_results.sql
  ✓ PASS  found AI_ASSIST.md
  ✓ PASS  Level 1: required files (10/10 pts)
  ✓ PASS  validation_queries.sql: file filled (no stub TODOs)
  ✓ PASS  validation_queries.sql: HAVING COUNT pattern found (duplicate check)
  ✓ PASS  validation_queries.sql: IS NULL check found (null integrity)
  ✓ PASS  validation_queries.sql: range check found (MIN/MAX or negative-fare count)
  ✓ PASS  validation_queries.sql: LEFT JOIN … IS NULL / NOT EXISTS orphan check (Task 1.4)
  ✓ PASS  Level 2: Task 1 validation queries (20/20 pts)
  ✓ PASS  schema_setup.sql: file filled (no stub TODOs)
  ✓ PASS  schema_setup.sql: vw_dim_zones view defined
  ✓ PASS  schema_setup.sql: vw_fact_trips view defined
  ✓ PASS  schema_setup.sql: negative fare filter (fare_amount >= 0) present in vw_fact_trips
  ✓ PASS  schema_setup.sql: pickup_datetime::TIMESTAMP cast present in vw_fact_trips
  ✓ PASS  Level 3: Task 2 star schema views (30/30 pts)
  ✓ PASS  data_dictionary.md: file filled (no stub TODOs)
  ✓ PASS  data_dictionary.md: 'Grain' heading/label present
  ✓ PASS  data_dictionary.md: primary key documented
  ✓ PASS  data_dictionary.md: measures list includes at least one aggregatable column
  ✓ PASS  Level 4: Task 3 data dictionary (15/15 pts)
  ✓ PASS  verification_results.sql: file filled (no stub TODOs)
  ✓ PASS  verification_results.sql: borough-level query found (Task 4.1)
  ✓ PASS  verification_results.sql: fare_amount revenue query found (Task 4.2)
  ✓ PASS  verification_results.sql: time-pattern query found (DOW or HOUR extraction) (Task 4.4)
  ✓ PASS  Level 5: Task 4 verification queries (15/15 pts)
  ✗ FAIL  screenshot missing: /home/runner/work/c55-data-week-9/c55-data-week-9/assignment/assets/borough_count.png not found
  ✓ PASS  Level 6: borough screenshot (0/5 pts)
  ✓ PASS  AI_ASSIST.md: all 4 sections present and filled in (2950 chars)
  ✓ PASS  Level 7: Task 5 AI log (5/5 pts)

Score: 95 / 100  (passing: 60)  pass=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants