Skip to content

fix(week12): starter + autograder lessons from cohort grading - #9

Merged
lassebenni merged 2 commits into
mainfrom
fix/week12-starter-cohort-lessons
Jul 24, 2026
Merged

fix(week12): starter + autograder lessons from cohort grading#9
lassebenni merged 2 commits into
mainfrom
fix/week12-starter-cohort-lessons

Conversation

@lassebenni

Copy link
Copy Markdown
Contributor

Summary

  • Fix Airflow 3 DagBag usage by removing include_examples (no longer accepted).
  • Rewrite starter docs so HTML comments never contain TODO; expand ASSIGNMENT_REPORT.md so backfill, idempotency row counts, and shared-deploy proof are explicit section stubs.
  • Clarify the DAG stub: required @dag fields including max_active_runs=1, and Gotcha Baraah A. #4 month-filter before write.
  • Strengthen .hyf/test.sh: Level 5 awards the remaining 5 pts only when both catchup=False and max_active_runs are present; Level 6 scores RUNBOOK (4) + AI_ASSIST (3) + ASSIGNMENT_REPORT (3); end reminder that screenshots / shared deploy / row counts are teacher-reviewed (autograder green ≠ pass).

Test plan

  • bash .hyf/test.sh on the starter (expects NotImplementedError / incomplete stub failures; script completes; score < 60)
  • Spot-check a completed student-like DAG still scores Level 5/6 when decorator + docs are filled
  • Confirm integrity test imports cleanly under Airflow 3 once tasks are implemented

Made with Cursor

Drop DagBag include_examples (Airflow 3), remove TODO from starter HTML
comments, expand ASSIGNMENT_REPORT for backfill/deploy proof, require
max_active_runs with catchup in the autograder, and clarify Gotcha #4
month-filter guidance in the DAG stub.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

This comment has been minimized.

Presence-only check (png/jpg/webp/gif); content and shared deploy stay teacher-reviewed. Rebalance doc points so Level 6 stays 10/100.

Co-authored-by: Cursor <cursoragent@cursor.com>
@lassebenni
lassebenni merged commit 7bef3a7 into main Jul 24, 2026
@github-actions

Copy link
Copy Markdown

📝 HackYourFuture auto grade

Assignment Score: 27 / 100 ❌

Status: ❌ Not passed
Minimum score to pass: 60
🧪 The auto grade is experimental and still being improved

Test Details

=== Week 12 Autograder — Orchestrated Pipeline ===
  ✓ PASS  found dags/taxi_pipeline.py
  ✓ PASS  found tests/test_dag_integrity.py
  ✓ PASS  found requirements.txt
  ✓ PASS  found RUNBOOK.md
  ✓ PASS  found ASSIGNMENT_REPORT.md
  ✓ PASS  found AI_ASSIST.md
  ✓ PASS  Level 1: required files (20/20 pts)
  ✗ FAIL  dags/taxi_pipeline.py: raise NotImplementedError still present — the DAG is not implemented
  ✓ PASS  dags/taxi_pipeline.py: defines a @dag with tasks
  ✓ PASS  Level 2: DAG implemented (5/15 pts)
  ✗ FAIL  dags/taxi_pipeline.py: only 1/3 expected tasks found (ingest, dbt_run, dbt_test)
  ✗ FAIL  dags/taxi_pipeline.py: no >> dependency chain found
  ✓ PASS  Level 3: sequential tasks (0/20 pts)
  ✗ FAIL  dags/taxi_pipeline.py: no uvx found — plain 'dbt' crashes on Python 3.14 (see Chapter 4)
  ✗ FAIL  dags/taxi_pipeline.py: no 'retries' found in default_args
  ✓ PASS  Level 4: uvx dbt + retries (0/20 pts)
  ✗ FAIL  dags/taxi_pipeline.py: no {{ ds }} / logical_date / get_current_context found — partition must come from the run date
  ✗ FAIL  dags/taxi_pipeline.py: catchup=False not found — required for safe normal operation
  ✗ FAIL  dags/taxi_pipeline.py: max_active_runs not found — set max_active_runs=1 on the @dag decorator (Gotcha #6); CLI --max-active-runs alone is not enough
  ✓ PASS  Level 5: parameterized runs (0/15 pts)
  ✗ FAIL  RUNBOOK.md: still a template (318 chars, 0 TODO marker(s)) — fill in all four sections
  ✗ FAIL  AI_ASSIST.md: still a template (204 chars, 0 TODO marker(s))
  ✓ PASS  ASSIGNMENT_REPORT.md: filled in (807 chars, no TODO left)
  ✗ FAIL  screenshots: none found — commit Graph, Grid/run, and task-log images into the PR (any folder)
  ✓ PASS  Level 6: documentation + screenshots (2/10 pts)

Score: 27 / 100  (passing: 60)  pass=false

Reminder: screenshot *content*, shared-Airflow deploy proof, and before/after
row counts are still teacher-reviewed. Autograder green is not a pass — a
high static score is necessary but not sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant