Mohamad bader AA - #3
Conversation
… dags instead of dags/bader
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Reopening to re-trigger grade workflow after checkout fix on main. |
Pick up ASSIGNMENT_REPORT TODO scoring, max_active_runs check, and screenshot presence (≥3 image files). Co-authored-by: Cursor <cursoragent@cursor.com>
Autograder note (teacher)The CI score is a static smoke test only (file presence + code patterns + docs/screenshot files). It does not grade:
Autograder 100 ≠ assignment pass. Teachers review those from your PR against the Week 12 deliverables. Please make sure |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Missing <3 screenshot images now forces pass=false (blocker). Co-authored-by: Cursor <cursoragent@cursor.com>
📝 HackYourFuture auto gradeAssignment Score: 100 / 100 ✅Status: ✅ Passed Test Details |
|
You didn't fill in the PR template, please do so next time. |
| @@ -0,0 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
don't think you need most of the files in include/dbt_project/
of this for the airflow to work!
|
|
||
| _Replace: describe ingest -> dbt_run -> dbt_test and why order matters._ | ||
| ingest_taxi_month() >> dbt_run >> dbt_test | ||
| chain matter because its linear and not exponential it follows that exact order in one line. |
There was a problem hiding this comment.
what does 'its linear and not exponential' mean in this context?
| ## Schedule choice and reason | ||
|
|
||
| _Replace this section._ | ||
| {{ds}} logical date. because choosing timenow i couldnt manually trigger runs on airflow choosing a specifec past date. |
There was a problem hiding this comment.
This is about what date you run with (logical date). The question is how you scheduled your workflow (in your case monthly, with backfill = False) and explain why.
What I built
dags/taxi_pipeline.py(schedule,ingest_taxi_month → dbt_run → dbt_test, partition from logical date, retries)include/dbt_project/RUNBOOK.mdASSIGNMENT_REPORT.mdAI_ASSIST.mdHow to review
dags/taxi_pipeline.py(schedule, task order,catchup=False, retries, partition date).ASSIGNMENT_REPORT.md; operations inRUNBOOK.md.AI_ASSIST.md.How to run
From a clean clone, with the Astro CLI installed:
astro dev start astro dev pytest tests/test_dag_integrity.py --args "-v"Then open the UI URL, add the
azure_pgconnection (Admin → Connections), unpausetaxi_pipeline, and trigger a run for a real month (e.g.2024-01-01).Prerequisite: your Week 10 dbt project in
include/dbt_project/and theazure_pgconnection to the shared Postgres.What reviewers should see (expected results)
Fill in what your run actually produces:
test_dag_integrity.pyresult: <e.g. all pass>Known limitations / out of scope
-(requires
az loginfirst), thenastro dev run connections add azure_pg --conn-uri "$PG_URL". | [Make sure the PGURL is populated from UI by clicking left panel Admin> connections OR http://c55-data-week-12.localhost:6563/connections]Self-check
bash .hyf/test.shpassesastro dev pytest tests/test_dag_integrity.pypassescatchup=Falseand retries are setASSIGNMENT_REPORT.md