Mohamad Bader AA - #12
Open
noneeeed wants to merge 1 commit into
Open
Conversation
📝 HackYourFuture auto gradeAssignment Score: 100 / 100 ✅Status: ✅ Passed Test Details |
jrnhofman
reviewed
Jul 25, 2026
| -- Return only the SQL expression (no SELECT, no semicolon). | ||
| NULL | ||
| {% endmacro %} | ||
| case |
There was a problem hiding this comment.
not wrong but you can also use NULLIF as per instruction for a cleaner expression
jrnhofman
reviewed
Jul 25, 2026
| (built from ___ and ___), and at least one known caveat | ||
| (e.g. rows dropped in staging, any WARN-severity tests). | ||
| description: "One row per completed NYC green taxi trip in January 2024, with | ||
| pickup/dropoff zone attributes folded in (OBT-style mart). Queried |
jrnhofman
reviewed
Jul 25, 2026
| COUNT(*) AS trip_count, | ||
| SUM(t.fare_amount)::numeric(10,2) AS total_fare, | ||
| AVG(t.tip_pct)::numeric(10,2) AS avg_tip_pct, | ||
| AVG(t.trip_distance)::numeric(10,2) AS avg_trip_distance |
There was a problem hiding this comment.
You don't necessarily need to add typecasting to each row (it's not wrong, but likely unnecessary)
jrnhofman
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.