Repository navigation
fix(masterclass): emit result-recorded mass in GeV (#1042) - #1043
Merged
EdwardMoyse merged 1 commit intoOct 9, 2026
Merged
Conversation
Contributor
Author
|
@EdwardMoyse Please review the pr when you have the free time |
|
🚀 Preview deployed: http://phoenix-pr-1043.surge.sh Built from 7870fcb. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1042
Summary
Fixes #1042 by ensuring the
result-recordedevent bus payload emits invariant mass values in GeV rather than MeV.Problem
When recording an invariant mass result in the masterclass panel (e.g., ~91 GeV for a Z candidate), the component emitted
result-recordedwithmass: this.liveMasswhich is in MeV (~91187 MeV). The histogram panel subscribed to this event and added the raw value without unit conversion. Since all histogram configs (ATLAS_MASS_HISTOGRAM, J/ψ, wide configs) use GeV ranges (e.g., 20–120 GeV for Z), all recorded results were going to overflow, leaving the visible histogram plot empty.Solution
massto GeV (result.mass / 1000) when emittingresult-recordedinMasterclassPanelOverlayComponent.recordResult(). Internal state (massResults) remains in MeV for panel UI and export consistency.result-recordedpayload emitsmassin GeV inevent-display.ts.masterclass-panel-overlay.component.test.tsto verifyresult-recordedemits mass values converted to GeV.Related Issues