Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


dir entry实际上没办法使用equal判断,比较选中状态的时候Bindings.equal()始终会返回false,所以实例文件夹的图标就全是未选中的图标,选中的实心图标根本没用上
改用id进行对比后返回对应的判断结果即修复,同时去除原有的测试(这个测试本来也测不出这个问题),改为新增两个独立业务(切换选择,缺失时回退)测试和一条断言
拿HMCL做二次开发的时候刚好遇到这个问题,顺手过来修一下(