Update h5z zfp subtree#272
Closed
lrknox wants to merge 250 commits into
Closed
Conversation
Flush stream after writing ZFP header
Fix array dimension order in zfp_field_* calls
Enable Security Checking reporting.
* Fix CMake error with HDF5 2.0.0 when HDF5_BUILD_FORTRAN is undefined, Fixes HDFGroup#154 * Updated the read-the-docs CI * Fix HDF5 tool compatibility for newer version naming * Link math library (-lm) to all test executables * added CI for develop and 1.14.0
* updated GitHub Actions versions, and added automatic updates with Dependabot
Bumps the github-actions group with 3 updates: [actions/checkout](https://github.com/actions/checkout), [github/codeql-action](https://github.com/github/codeql-action) and [actions/upload-artifact](https://github.com/actions/upload-artifact). Updates `actions/checkout` from 3 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v6) Updates `github/codeql-action` from 3 to 4 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v3...v4) Updates `actions/upload-artifact` from 4 to 5 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: github/codeql-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…DFGroup#158) Bumps the github-actions group with 1 update: [actions/upload-artifact](https://github.com/actions/upload-artifact). Updates `actions/upload-artifact` from 5 to 6 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v5...v6) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…DFGroup#160) Use BUILD_RPATH with a generator expression to resolve zfp at build time, and INSTALL_RPATH "$ORIGIN" for a relocatable install. This replaces BUILD_WITH_INSTALL_RPATH which conflated the two contexts. Bumps cmake_minimum_required to 3.16 for generator expression support in BUILD_RPATH.
…DFGroup#161) Bumps the github-actions group with 1 update: [actions/upload-artifact](https://github.com/actions/upload-artifact). Updates `actions/upload-artifact` from 6 to 7 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v6...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove GNU Make/autotools build system, keep CMake only - Remove Makefile, config.make, src/Makefile, test/Makefile, docs/Makefile - Remove .travis.yml (deprecated CI using Make) - Remove .readthedocs.yaml (ReadTheDocs config) - Remove autotools build step from GitHub Actions workflow - Add CMake 'docs' target for building Sphinx documentation - Update documentation to remove Make references - Fix malformed hyperlink in docs/index.rst - Update README.md with CMake-only build instructions * Add code coverage job to GitHub Actions workflow * Add GitHub Actions and ReadTheDocs badges to README * Fix Windows CI: replace wget with curl for HDF5 download * Support Make-built ZFP via FindZFP.cmake fallback ZFP can be built with either CMake or its vanilla Makefile. When built with make, no ZFPConfig.cmake is generated. This adds: - cmake/FindZFP.cmake module that locates headers and library directly and creates the zfp::zfp imported target as a fallback - CMakeLists.txt tries CONFIG mode first, falls back to FindZFP module - CI job that builds ZFP with make to test this path - Updated installation docs to cover both ZFP build methods * Extract ZFP version from headers in FindZFP.cmake When ZFP is built with make, the ZFP_VERSION_MAJOR/MINOR/PATCH variables are not set, causing test compilation to fail with 'invalid suffix "x" on integer constant' because ZFP_LIB_VERSION ends up as 0x (empty version components). Parse the version from zfp/version.h (ZFP 1.0+) or zfp.h (older) to fix this.
…FGroup#164) Bumps the github-actions group with 1 update: [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `codecov/codecov-action` from 3 to 5 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…DFGroup#168) Use H5Dget_chunk_info_by_coord (HDF5 1.12+) to dynamically find the chunk's file offset instead of the hardcoded value 3496. HDF5 2.1.0 changed internal file layout so the chunk no longer lives at that address, causing the raw-byte corruption to miss the ZFP stream and yielding only 652 differing values instead of the expected 1408.
…FGroup#169) Bumps the github-actions group with 1 update: [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `codecov/codecov-action` from 5 to 7 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5...v7) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…up (HDFGroup#170) Bumps the github-actions group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 6 to 7 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v6...v7) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Allow shared plugin install destination to be overridden. * Use CACHE STRING for H5Z_ZFP_PLUGIN_INSTALL_DIR, not CACHE PATH CMake silently absolutizes relative values of CACHE PATH/FILEPATH variables passed via -D on the command line, anchoring them to the current working directory (the build dir) rather than CMAKE_INSTALL_PREFIX. That broke the documented "relative to CMAKE_INSTALL_PREFIX" behavior for the most common invocation, e.g.: cmake -DCMAKE_INSTALL_PREFIX=<prefix> -DH5Z_ZFP_PLUGIN_INSTALL_DIR=lib/plugin .. installed to <build-dir>/lib/plugin instead of <prefix>/lib/plugin. CACHE STRING isn't subject to this normalization and still supports absolute-path overrides, since install(DESTINATION) resolves relative-vs-absolute from the string content, not the cache type. Verified with cmake --install across three cases (default, relative -D override, absolute -D override): all three now land under CMAKE_INSTALL_PREFIX as expected except the absolute case, which is used verbatim as intended. --------- Co-authored-by: Scot Breitenfeld <brtnfld@hdfgroup.org>
lrknox
requested review from
ajelenak,
bmribler,
brtnfld,
fortnern,
glennsong09,
jhendersonHDF and
mattjala
as code owners
July 16, 2026 17:14
Collaborator
Author
|
More comprehensive changes to enable subtree updates required in #273. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.