Skip to content

Add BitRound filter and its plugin ID 32032#269

Merged
ajelenak merged 3 commits into
masterfrom
bitround-plugin
Jul 16, 2026
Merged

Add BitRound filter and its plugin ID 32032#269
ajelenak merged 3 commits into
masterfrom
bitround-plugin

Conversation

@ajelenak

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread BITROUND/example/test/testCM.sh Outdated
# If you do not have access to either file, you may request a copy from
# help@hdfgroup.org.

# This file is for use of h5cc created with the autotools process

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testCM.sh. Line 13 is the same in the test.sh file. Probably line 13 should end with "the CMake process"?


set (CMAKE_C_COMPILER cc)
set (CMAKE_Fortran_COMPILER ftn)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason there isn't this line?
set (CMAKE_CXX_COMPILER CC)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I just copied over from BitGroom and made changes where I thought was appropriate. I can add it in.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked and none of these files for several other plugins are missing the CXX line so I will leave it as-is here, too.

@lrknox

lrknox commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

@ajelenak - a few minor questions you can check if you want. The third is whether the pgi files should be updated to nvc/nvhpc sometime? I'll leave merging it to you; if you make any changes and need it approved again, let me know.

@ajelenak

Copy link
Copy Markdown
Contributor Author

whether the pgi files should be updated to nvc/nvhpc sometime?

Don't know what this is. I pushed one typo fix. Not sure if it will need your approval again. The buttons are green so far.

@ajelenak
ajelenak merged commit 1e0a818 into master Jul 16, 2026
34 of 36 checks passed
@ajelenak
ajelenak deleted the bitround-plugin branch July 16, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants