Repository navigation
RHELMISC-34338: queuetest: allow assigning multiple machines to HLK roles via JSON - #81
Conversation
…oles via JSON The -sup parameter now accepts a JSON object that maps role names to machine lists instead of a single machine name. This allows tests with multiple roles (e.g. MC, SC) to each get their own machine. Roles not specified in the JSON fall back to the primary test machine. Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the queuetest function in tools/toolsHCK.ps1 to allow the -sup parameter to accept a JSON object mapping HLK role names to arrays of machine names, replacing the previous single-machine string behavior. The reviewer recommended addressing backward compatibility for cases where a plain machine name is still passed, and suggested using more idiomatic PowerShell dynamic member access instead of verbose .PSObject.Properties syntax.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
3 participants
The sup parameter now accepts a JSON object that maps role names to machine lists instead of a single machine name. This allows tests with multiple roles (e.g. MC, SC) to each get their own machine. Roles not specified in the JSON fall back to the primary test machine.