Repository navigation
fix(agent): stop the agent and close redis on shutdown, document the single bean - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the review of #18.
GuardMiddleware.shutdown()now runs under the initialization mutex, so it cannot interleave with a first-requestinitialize(), and is safe to call twice. It also closes the middleware's ownredisHandler, and wheninitialize()never ran it stops the injected agent handler directly, so a GuardAgent created withcfg.redisno longer leaks its persistence connection and daemon thread. The README now states that exactly oneAgentHandlerProtocolbean is used (two fail startup unless one is@Primary) and gives the guard-agent-jvm dependency line. I added tests for context close, shutdown without initialize, double shutdown and the redis close.