Repository navigation
fix(middleware): expose Flusher, Hijacker and Unwrap on the response wrapper - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42
The
statusObserverresponse wrapper now implementsUnwrap,FlushandHijack.Unwrapreturns the underlying writer sohttp.NewResponseControllerreaches the deadline and full-duplex controls.Flushpins the implicit 200 and delegates to the real writer, so SSE and other streaming handlers reach the client as they write. In held mode (aCustomResponseModifieris configured) the modifier must see the whole response, soFlushis a no-op there and the response is sent at release.Hijackdelegates to the underlying writer (http.ErrNotSupportedwhen it cannot) and marks the connection as taken: the middleware then skips the response pass and the held-response release, so a hijacked connection is left alone.Tests run against a real
httptestserver: an SSE handler whose first event must arrive before the handler returns,http.ResponseController.Flush, a raw hijack exchange with and without a modifier, and a held response that is still modified after aFlush.