Repository navigation
fix(adapters): set explicit text/plain content type on blocked responses - #22
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Thanks for opening your first pull request on djangoapi-guard! Quick checklist before review (most of these are enforced by CI, but worth a glance):
See CONTRIBUTING.md for the full workflow and the Code of Conduct for the community standards we follow. Welcome aboard — a maintainer will review shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DjangoResponseFactory.create_responsefell back to Django's defaulttext/html; charset=utf-8. UnderX-Content-Type-Options: nosniff(applied by default), that is exactly the gap fastapi-guard fixed in #144: the block page should be explicittext/plain.create_responsenow passescontent_type="text/plain; charset=utf-8". Redirect responses are untouched (no body, no content type).custom_error_responsestext staystext/plain, and acustom_response_modifiercan still set its own content type.Tests
tests/test_block_response_content_type.py, mirroring fastapi-guard's test of the same name: block response is plain text with nosniff, custom error message stays plain text, modifier override wins.test_django_response_factory_createwith the header assertion.