System Center Pagination - #919
Open
nbeatty-gpa wants to merge 11 commits into
Open
Conversation
nbeatty-gpa
force-pushed
the
newPagination2
branch
2 times, most recently
from
August 7, 2026 20:35
1f02e61 to
2b4807b
Compare
nbeatty-gpa
marked this pull request as ready for review
August 7, 2026 20:43
nbeatty-gpa
force-pushed
the
newPagination2
branch
2 times, most recently
from
August 14, 2026 13:11
ebf498a to
57d2bbc
Compare
nbeatty-gpa
force-pushed
the
newPagination2
branch
from
August 14, 2026 14:12
57d2bbc to
afc1f6d
Compare
nbeatty-gpa
force-pushed
the
newPagination2
branch
from
August 14, 2026 14:15
afc1f6d to
1191980
Compare
prestoncraw
reviewed
Aug 14, 2026
| Location.Name, | ||
| MeterAssetGroup.AssetGroupID | ||
| HAVING MeterAssetGroup.AssetGroupID = {{0}} | ||
| ORDER BY {postData.OrderBy} {(postData.Ascending ? "ASC" : "DESC")} |
Contributor
There was a problem hiding this comment.
This introduces SQLInjection {postData.OrderBy}
prestoncraw
reviewed
Aug 14, 2026
| AssetAssetGroup.AssetGroupID | ||
| HAVING AssetAssetGroup.AssetGroupID = {0}"; | ||
| HAVING AssetAssetGroup.AssetGroupID = {{0}} | ||
| ORDER BY {postData.OrderBy} {(postData.Ascending ? "ASC" : "DESC")} |
Contributor
There was a problem hiding this comment.
This introduces SQLInjection {postData.OrderBy}
prestoncraw
reviewed
Aug 14, 2026
| SELECT * | ||
| FROM ChannelDetail | ||
| WHERE ID in ({string.Join(", ", connectedChannels.Select(channels => channels.ID))}) | ||
| ORDER BY {postData.OrderBy} {(postData.Ascending ? "ASC" : "DESC")} |
Contributor
There was a problem hiding this comment.
This introduces SQLInjection {postData.OrderBy}
prestoncraw
reviewed
Aug 14, 2026
| { | ||
| string sql = $@"SELECT UserAccount.*, UserAccount.Name as AccountName | ||
| FROM SecurityGroupUserAccount JOIN UserAccount ON UserAccountID = UserAccount.ID WHERE SecurityGroupID = {{0}} | ||
| ORDER BY {postData.OrderBy} {(postData.Ascending ? "ASC" : "DESC")} |
Contributor
There was a problem hiding this comment.
This introduces SQLInjection {postData.OrderBy}
prestoncraw
requested changes
Aug 14, 2026
prestoncraw
left a comment
prestoncraw
left a comment
Contributor
There was a problem hiding this comment.
I didnt go through everything yet but theres multiple sql injections that were introduced.
Contributor
Author
|
added whitelisting per this afternoon's conversation |
nbeatty-gpa
force-pushed
the
newPagination2
branch
from
August 14, 2026 19:37
896a0db to
fa11956
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pagination to:
ValueListGroupItemMeterChannelcomponentsSourceImpedancesAssetChannelsAssetGroupcomponentsLineSegmentGroupUsers