Psuedo-class selector :text producing errors and incorrect results

[jakejackson1]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

1. If doing ->is(':text') on a text node an error is produced.
2. If doing ->find(':text') it won't match <input /> tags without a type (which are considered text inputs). See https://api.jquery.com/text-selector/

Issue Number: #49

Fixes #49

What is the new behavior?

1. Selectors no longer fatal on non-element nodes

The traverser assumed every node in a match set was a DOMElement and called element-only APIs
(getElementsByTagName(), tagName, getAttribute(), hasAttribute()) on it. A match set can legitimately hold
text, comment, CDATA and processing instruction nodes — contents() produces exactly that — so
$singleTextNode->is(':text') blew up with Call to undefined method DOMText::getElementsByTagName().

This is fixed as a class of bug, not just at the one line in the stack trace. A non-element node now simply does not
match an element selector:

• CSS\DOMTraverser::matchesSimpleSelector() returns false for any node that is not a DOMElement. This is the
  single funnel every selector match passes through. matchesSelector(), matchesSimpleSelector() and combine()
  now accept a DOMNode rather than a DOMElement so they can make that decision instead of raising a TypeError.
  (This also fixes combineDirectDescendant(), which could hand a DOMDocument to a DOMElement parameter.)
• initialMatchOnElement(), initialMatchOnID() and initialMatchOnClasses() skip nodes that cannot hold elements.
• CSS\DOMTraverser\PseudoClass::elementMatches() and CSS\DOMTraverser\Util::matchesAttribute() /
  matchesAttributeNS() guard against non-elements too, since they are reachable as public API in their own right.

One related consistency fix was needed to make the committed spec pass: initialMatchOnElement() now captures the
node itself when the element selector is the wildcard (*, which is what a bare :text / :foo selector expands
to). initialMatchOnID() and initialMatchOnClasses() already test the node itself for their own selectors, and
initialMatchOnElement() already did so for a named element and for the document element — the wildcard was the odd
one out. Without this, $input->is(':text') could never be true for the input itself.

The legacy engine (CSS\QueryPathEventHandler, still used by remove() and replaceAll()) already filtered
non-element nodes out in its constructor, so it did not need the crash fix.

2. :text now means what it means in jQuery

:text was implemented as [type="text"], which matched any element carrying that attribute and missed a bare
<input />. It now matches jQuery: an input whose type attribute is absent (text is an input's default
type) or is text, compared case-insensitively. It does not, and never did, indicate whether a node is a text
node.

Fixed in both engines — CSS\DOMTraverser\PseudoClass::isTextInput() and
CSS\QueryPathEventHandler::textInput() — so find(':text') and remove(':text') / replaceAll(':text') agree.

Tests

The committed spec in tests/Issues/Issue49Test.php passes unchanged. Added alongside it:

• testTextSelectorOnlyMatchesTextInputs — :text matches <input type="text">, bare <input> and
  <input type="TEXT">, and not password / checkbox / submit / <textarea> / <button>.
• testTextSelectorMatchesTheInputItself — the same variants asserted through is() on the input itself.
• testTextSelectorInTheLegacyEngine — remove(':text') selects the same set as find(':text').
• testSelectorsAgainstATextNodeDoNotThrow — element, wildcard, class, ID, attribute, attribute-value,
  pseudo-class and descendant selectors against a text-node collection, through both is() and find(), plus
  filter().
• testSelectorsAgainstACommentNodeDoNotThrow — the same for a DOMComment.
• testSelectorsAgainstCdataAndProcessingInstructionNodesDoNotThrow — the same for DOMCdataSection and
  DOMProcessingInstruction (via qp() on XML).
• testMixedNodeMatchSetStillMatchesItsElements — a match set mixing a text node with an element still matches the
  element it holds.

All 9 tests in the file fail without the src/ changes. Full suite: 286 tests, 1084 assertions, 0 failures
(2 pre-existing skips for create_function on PHP 8). composer run lint and composer run lint:min-php are clean.

Does this introduce a breaking change?

• Yes
• No

:text changes meaning, deliberately: it no longer matches non-input elements that happen to carry
type="text", and it now matches <input> with no type. This is the point of the issue and brings the selector
in line with jQuery.

Additionally, a wildcard element selector now also considers the context node itself, not only its descendants
(see above), so e.g. $el->find('*') includes $el. This makes the wildcard consistent with the ID and class
initial-match paths, and no existing test changed behaviour because of it.

Other information

Conflict with #51. PR #51 changes is() so that it only tests the elements in the match set, not their
descendants (matching jQuery). The committed spec on this branch contains
$this->assertTrue($q->is(':text')); where $q holds the <div> and only its children are :text — that
assertion relies on the current descendant semantics and will become false once #51 lands. I deliberately did not
touch is()'s descendant-vs-set semantics here; that assertion needs to be reconciled (flipped to
assertFalse, or the fixture changed) when the two branches meet. Everything else in this PR is orthogonal to #51:
the crash fix lives in the traverser, and :text is a pseudo-class evaluation. Note that under #51 the sibling
assertion $textNode->is(':text') (which actually holds the first <input>, not a text node) continues to pass,
because this PR makes the wildcard initial match consider the node itself.

The other jQuery input pseudo-classes (:radio, :checkbox, :password, :submit, :button, …) still use the
old [type=x] implementation and have the same divergence from jQuery in a milder form (e.g. jQuery's :button
also matches <button>). Left alone deliberately — out of scope for #49.

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.45%. Comparing base (296d828) to head (e23694e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/CSS/DOMTraverser/Util.php	75.00%	2 Missing ⚠️
src/CSS/DOMTraverser.php	92.30%	1 Missing ⚠️
src/CSS/DOMTraverser/PseudoClass.php	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main      #50   +/-   ##
=========================================
  Coverage     89.44%   89.45%           
- Complexity     1342     1358   +16     
=========================================
  Files            26       26           
  Lines          3023     3054   +31     
=========================================
+ Hits           2704     2732   +28     
- Misses          319      322    +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.