Skip to content

Test that text after a Plane 2 character is substituted from an empty font cache (#828) - #849

Merged
jakejackson1 merged 1 commit into
gravitypdffrom
test/837-sip-coverage-gaps
Nov 4, 2026
Merged

jakejackson1 merged 1 commit into
gravitypdffrom
test/837-sip-coverage-gaps

Conversation

@gravitypdf-bot

Copy link
Copy Markdown

Adds the one test #847 showed gravitypdf was missing: text after a Plane 2 character is still substituted when nothing of backupSIPFont is in the font cache yet (#828). No code changes, so no changelog entry.

gravitypdf-v6 covers this in SubstitutionFontCacheTest, added by #830. Here, the new test uses no font packages, so the fonts have no ranges files and each is read from the font itself:

  • Text: Next 𠀀 then ⇒ ā in Garuda, from an empty font cache.
  • Expected fonts: Garuda, Sun-ExtB, Garuda, the core Symbol font, DejaVu Sans Condensed.

Left out

Two other v6 test cases aren't ported, because gravitypdf already covers them:

  • A font with a sip-ext font keeps the Plane 2 text it has: SubstitutionRunSplitTest::testPlaneTwoTextAFontWithASipExtFontHasStaysInIt.
  • Core font text from an empty font cache: CoreFontBackupSubstitutionTest.

Testing

/simplify wasn't run, as this is one short test that reuses the TempFontDirectory trait.

… font cache (#828)

gravitypdf-v6 covers this in SubstitutionFontCacheTest, from #830. gravitypdf has no test of it: its other first-render tests use a core font, or read the fonts from ranges files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jakejackson1
jakejackson1 merged commit 60d1ee6 into gravitypdf Nov 4, 2026
9 checks passed
@jakejackson1
jakejackson1 deleted the test/837-sip-coverage-gaps branch November 4, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants