Repository navigation
Test that text after a Plane 2 character is substituted from an empty font cache (#828) - #849
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the one test #847 showed
gravitypdfwas missing: text after a Plane 2 character is still substituted when nothing ofbackupSIPFontis in the font cache yet (#828). No code changes, so no changelog entry.gravitypdf-v6covers this inSubstitutionFontCacheTest, added by #830. Here, the new test uses no font packages, so the fonts have no ranges files and each is read from the font itself:Next 𠀀 then ⇒ āin Garuda, from an empty font cache.Left out
Two other v6 test cases aren't ported, because
gravitypdfalready covers them:sip-extfont keeps the Plane 2 text it has:SubstitutionRunSplitTest::testPlaneTwoTextAFontWithASipExtFontHasStaysInIt.CoreFontBackupSubstitutionTest.Testing
composer cs: clean./simplifywasn't run, as this is one short test that reuses theTempFontDirectorytrait.