Let vector modifier nodes operate on graphic content by recursing into groups - #4431
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 4/5
- In
node-graph/nodes/vector/src/vector_nodes.rs(map_points), derivingindexfrompositions_mut().enumerate()can reset point indices to 0 for each nested vector in aGraphic, which may break nodes that rely on globally stable indexing and produce incorrect per-point results; preserve a cumulative index across nested vectors (or document/adjust expected indexing semantics) to de-risk regressions.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="node-graph/nodes/vector/src/vector_nodes.rs">
<violation number="1" location="node-graph/nodes/vector/src/vector_nodes.rs:1709">
P2: `map_points` now iterates via `V::vector_elements_mut`, and the `index` passed into the node's context is derived from `positions_mut().enumerate()`, which restarts at 0 for every nested vector inside a `Graphic`. Previously the node accepted a single `Item<Vector>` and the index ran 0..n for the whole path. When the mapped upstream node keys off `index` (common for noise/colour/pattern nodes), each vector in a group now re-indexes from 0 rather than continuing across the group, so the per-point values change for grouped content. Consider threading a monotonically increasing index across all collected vectors so the mapping stays consistent with the former single-vector behavior.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
… flattening its input
134096f to
ab483a7
Compare
ab483a7 to
01cfce3
Compare
Performance Benchmark Results
|
Performance Benchmark Results
|
Performance Benchmark Results
|
1 participant
Mostly closes #1929 except those in the Measure category.