Change hardcoded colors to more neutral, and add some basic color schemes#154
Closed
ddagunts wants to merge 1 commit into
Closed
Change hardcoded colors to more neutral, and add some basic color schemes#154ddagunts wants to merge 1 commit into
ddagunts wants to merge 1 commit into
Conversation
Author
|
I can see the code is in a state of modernization, so it's understandable if this change is undesirable and declined. I would ask, in such a case, to consider changing the hue on the message bubbles to a darker green. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, first off, a big thanks for the GrapheneOS project. I am hoping you will consider this PR, or consider a similar/better implementation. The default color scheme in the Messaging app for incoming messages has white text on green background. Green and white is a fairly common color blindness - for me it is difficult to read incoming messages. There are other messaging and SMS apps available, but unfortunately I haven't found an SMS app that works reliably in secondary profiles (well known issues).
This changes the old green defaults to grays, and provides a few color schemes which, while not designer quality, do seem to be easier to read.
Thank you!