Skip to content

Fix issues 8253, 12325, 11942, 11566, 12580, 14117 - #14540

Open
manish08k wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
manish08k:fix/issues-69
Open

Fix issues 8253, 12325, 11942, 11566, 12580, 14117#14540
manish08k wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
manish08k:fix/issues-69

Conversation

@manish08k

Copy link
Copy Markdown

Description

This PR addresses the following issues in python-docs-samples:

Changes

  • Updated Cloud SQL sample region tag configuration.
  • Added the required logging dependency configuration.
  • Updated the authoring guide reference.
  • Replaced the Eventarc storage handler Procfile with a Dockerfile.
  • Updated Composer regex handling.
  • Updated Gemini model references across the affected samples.

Testing

  • Applied all changes cleanly.
  • Ran git diff --check.
  • Verified the resulting changes before committing.

Related Issues

Fixes #8253
Fixes #12325
Fixes #11942
Fixes #11566
Fixes #12580
Fixes #14117

@manish08k
manish08k requested review from a team as code owners August 26, 2026 08:25
@snippet-bot

snippet-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: cloudsql api: composer Issues related to the Managed Service for Apache Airflow API. api: eventarc Issues related to the Eventarc API. labels Aug 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various samples to use the gemini-2.5-flash model, cleans up region tags in Cloud SQL SQLAlchemy samples, refactors Composer DAG version parsing to handle optional components, and adds a Dockerfile for the Eventarc storage handler. Feedback on these changes includes a recommendation to define WORKDIR earlier in the new Dockerfile to prevent copying dependency manifests to the root directory, and a reminder to pin the newly added google-cloud-logging dependency to a specific version in accordance with the repository's style guidelines.

Comment on lines +22 to +32
# Copy application dependency manifests to the container image.
# Copying this separately prevents re-running pip install on every code change.
COPY requirements.txt ./

# Install production dependencies.
RUN pip install -r requirements.txt

# Copy local code to the container image.
ENV APP_HOME /app
WORKDIR $APP_HOME
COPY . ./

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Setting the working directory (WORKDIR) after copying and installing dependencies causes requirements.txt to be copied to the root directory (/) of the container. It is a best practice to define WORKDIR first so that all subsequent copy and run commands are executed within the designated application directory (e.g., /app), keeping the container filesystem clean and organized.

ENV APP_HOME /app
WORKDIR $APP_HOME

# Copy application dependency manifests to the container image.
# Copying this separately prevents re-running pip install on every code change.
COPY requirements.txt ./

# Install production dependencies.
RUN pip install -r requirements.txt

COPY . ./

@@ -0,0 +1 @@
google-cloud-logging>=3.4.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the repository's AUTHORING_GUIDE.md, all dependencies in requirements.txt should be pinned to a specific version using == to ensure reproducible environments and prevent unexpected breakages from upstream updates.

google-cloud-logging==3.4.0
References
  1. All dependencies should be pinned to a specific version, as in this example: Flask==1.1.1 (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudsql api: composer Issues related to the Managed Service for Apache Airflow API. api: eventarc Issues related to the Eventarc API. samples Issues that are directly related to samples.

Projects

None yet

2 participants