Skip to content

chore(generative_ai): remove samples migrated to genai - #14531

Merged
holtskinner merged 1 commit into
GoogleCloudPlatform:mainfrom
XrossFox:vertex-to-genai-vision-models-cleaning
Aug 24, 2026
Merged

chore(generative_ai): remove samples migrated to genai#14531
holtskinner merged 1 commit into
GoogleCloudPlatform:mainfrom
XrossFox:vertex-to-genai-vision-models-cleaning

Conversation

@XrossFox

Copy link
Copy Markdown
Contributor

Description

Deletes embeddings and model tuning examples that have been migrated to use the new google-genai SDK.

Fixes b/540949366

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Aug 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several Python example files, tests, and configuration files related to Vertex AI text/multimodal embeddings and supervised tuning. Specifically, it deletes code examples for batch text embedding, lower-dimension embeddings, multimodal embeddings, and tuning job cancellation, along with their corresponding test suites and dependency requirements. There are no review comments, so we have no feedback to provide.

 Deletes embeddings and model tuning examples that have been migrated to use the new `google-genai` SDK.
@XrossFox
XrossFox force-pushed the vertex-to-genai-vision-models-cleaning branch from f2de68d to dc227de Compare August 21, 2026 16:29

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any references to the deleted samples on DevSite, LGTM!

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any references in use for this sample in devsite, LGTM

@XrossFox
XrossFox marked this pull request as ready for review August 24, 2026 17:12
@XrossFox
XrossFox requested review from a team as code owners August 24, 2026 17:12
@snippet-bot

snippet-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@XrossFox XrossFox closed this Aug 24, 2026
@XrossFox
XrossFox deleted the vertex-to-genai-vision-models-cleaning branch August 24, 2026 17:18
@XrossFox
XrossFox restored the vertex-to-genai-vision-models-cleaning branch August 24, 2026 18:33
@XrossFox XrossFox reopened this Aug 24, 2026

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holtskinner
holtskinner merged commit 25bbbcb into GoogleCloudPlatform:main Aug 24, 2026
16 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants