Skip to content

chore(functions/v2/datastore): update dependencies for hello-datastore#14354

Merged
iennae merged 1 commit into
GoogleCloudPlatform:mainfrom
XrossFox:package-update-protobuf-hello-datastore
Jun 26, 2026
Merged

chore(functions/v2/datastore): update dependencies for hello-datastore#14354
iennae merged 1 commit into
GoogleCloudPlatform:mainfrom
XrossFox:package-update-protobuf-hello-datastore

Conversation

@XrossFox

@XrossFox XrossFox commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

  • Update protobuf, google-api-core, functions-framework, google-cloud-datastore, and cloudevents to latest versions
  • Remove python version constraint for pytest in requirements-test.txt

Fixes b/8462433

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

 - Update `protobuf`, `google-api-core`, `functions-framework`, `google-cloud-datastore`, and `cloudevents` to latest versions
 - Remove python version constraint for pytest in `requirements-test.txt`
@product-auto-label product-auto-label Bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependency versions in requirements.txt and requirements-test.txt for the hello-datastore Cloud Function. The reviewer identified that several of the updated dependency versions (specifically protobuf, google-api-core, and google-cloud-datastore) do not exist on PyPI, which will cause installation failures.

Comment thread functions/v2/datastore/hello-datastore/requirements.txt
@XrossFox

Copy link
Copy Markdown
Contributor Author

This sample has been tested locally. Note that this sample does not use nox, so it was tested on the base python version available on my system: 3.13.

image

@Kef131 Kef131 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@XrossFox XrossFox marked this pull request as ready for review June 25, 2026 23:43
@XrossFox XrossFox requested review from a team as code owners June 25, 2026 23:43
@iennae iennae merged commit ce8d461 into GoogleCloudPlatform:main Jun 26, 2026
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants