feat(storage): support delete source objects on compose#14349
feat(storage): support delete source objects on compose#14349nidhiii-27 wants to merge 2 commits into
Conversation
Add deleteSourceObjects parameter to compose sample. Updated test to assert both delete behavior scenarios. [Generated-by: AI]
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for the "delete_source_objects" parameter in the "compose_file" snippet, enabling the deletion of source objects after composition, and includes unit tests to verify both the default and deletion behaviors. The reviewer suggested refactoring the conditional print statements in "storage_compose_file.py" to use a conditional suffix string, which reduces code duplication and improves maintainability.
| if delete_source_objects: | ||
| print( | ||
| "New composite object {} in the bucket {} was created by combining {} and {}. Source objects were deleted.".format( | ||
| destination_blob_name, bucket_name, first_blob_name, second_blob_name | ||
| ) | ||
| ) | ||
| else: | ||
| print( | ||
| "New composite object {} in the bucket {} was created by combining {} and {}".format( | ||
| destination_blob_name, bucket_name, first_blob_name, second_blob_name | ||
| ) | ||
| ) |
There was a problem hiding this comment.
The print statements for when delete_source_objects is True vs False are highly duplicated. We can simplify this by using a conditional suffix string, which reduces duplication and improves maintainability.
suffix = " Source objects were deleted." if delete_source_objects else ""
print(
"New composite object {} in the bucket {} was created by combining {} and {}.{}".format(
destination_blob_name, bucket_name, first_blob_name, second_blob_name, suffix
)
)- Reordered imports in snippets_test.py to satisfy flake8. - Refactored storage_compose_file.py print statements to avoid duplication. [Generated-by: AI]
product-auto-label
Bot
added
api: storage
|
Verified locally: https://screenshot.googleplex.com/xqBVCJ3FR6FVuHQ.png |
1 participant
Updates compose file sample to support deleting source objects optionally. Fixes b/441557254