Skip to content

Fixed mismapped compute resources - #18552

Open
melinath wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
melinath:mismapped-compute-resources
Open

Fixed mismapped compute resources#18552
melinath wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
melinath:mismapped-compute-resources

Conversation

@melinath

@melinath melinath commented Aug 6, 2026

Copy link
Copy Markdown
Member

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

modular-magician commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 951ff90:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 15 insertions(+), 15 deletions(-)
google-beta provider View Diff 12 files changed, 15 insertions(+), 15 deletions(-)
terraform-google-conversion View Diff 2 files changed, 2 insertions(+), 2 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1556 1459 95 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath, @SirGitsalot, @andyzh4812 VCR tests complete for 951ff90!

@melinath

melinath commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

The VCR failures look unrelated. The list resource changes were unexpected but look harmless - ListPages falls back to items if the ItemName isn't present in the response (and none of the VCR tests started failing as a result of this change). I checked the debug logs for TestAccComputeRegionCompositeHealthCheckListQuery_generated & verified that the list method returns "items", not "regionCompositeHealthChecks" or "compositeHealthChecks".

@melinath

melinath commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

The TGC diff is unexpected but doesn't seem to be causing test failures so it's probably fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants