networkservices: add list resources - #18550
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d0aa96a: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 24 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode Caution Panic occurred during VCR tests 🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details. Please fix the issue to complete your PR. View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bb636c0: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode Caution Panic occurred during VCR tests 🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details. Please fix the issue to complete your PR. View the build log |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9658f5b: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
9658f5b to
8f3cc10
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8f3cc10: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode Caution Panic occurred during VCR tests 🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details. Please fix the issue to complete your PR. View the build log |
8f3cc10 to
d5687e1
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d5687e1: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode Caution Panic occurred during VCR tests 🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details. Please fix the issue to complete your PR. View the build log |
429c32f to
d5687e1
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 429c32f: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode Caution Panic occurred during VCR tests 🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details. Please fix the issue to complete your PR. View the build log @BBBmau, @andyzh4812 VCR tests complete for 429c32f! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d5687e1: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode Caution Panic occurred during VCR tests 🔴 RECORDING mode: The provider crashed with a panic. Please check the build log for details. Please fix the issue to complete your PR. View the build log @BBBmau, @andyzh4812 VCR tests complete for d5687e1! |
All networkservices resources with hardcoded 'locations/global' in their base_url need the location parameter marked as required for list queries to work properly. The list query test framework needs required scope properties to generate the correct filter configuration. Fixed resources: - Mesh - Gateway - EndpointPolicy - GrpcRoute - HttpRoute - ServiceLbPolicies - TcpRoute - TlsRoute - EdgeCacheOrigin - EdgeCacheKeyset - EdgeCacheService - AgentGateway (already had required, added default_value)
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b00cf05: Diff reportYour PR generated the following diffs in downstream repositories:
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_services_edge_cache_keyset" "primary" {
location = # value needed
}
Resource: resource "google_network_services_edge_cache_origin" "primary" {
location = # value needed
}
Resource: resource "google_network_services_edge_cache_service" "primary" {
location = # value needed
}
Resource: resource "google_network_services_endpoint_policy" "primary" {
location = # value needed
}
Resource: resource "google_network_services_http_route" "primary" {
location = # value needed
}
Resource: resource "google_network_services_tcp_route" "primary" {
location = # value needed
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 124 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. More than 100 tests failed in replaying; this is too many to display on GitHub. View the Cloud Build logs to see the full list. View the replaying VCR build log Step 2: Recording Mode More than 100 tests ran in recording mode; this is too many to display on GitHub. View the Cloud Build logs to see the result summary. Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @BBBmau, @andyzh4812 VCR tests complete for b00cf05! |
2 participants
Adds list-resource generation for the following networkservices resources:
google_networkservices_agent_gatewaygoogle_networkservices_authz_extensiongoogle_networkservices_edge_cache_keysetgoogle_networkservices_edge_cache_origingoogle_networkservices_edge_cache_servicegoogle_networkservices_endpoint_policygoogle_networkservices_gatewaygoogle_networkservices_grpc_routegoogle_networkservices_http_routegoogle_networkservices_lb_route_extensiongoogle_networkservices_lb_traffic_extensiongoogle_networkservices_meshgoogle_networkservices_multicast_consumer_associationgoogle_networkservices_multicast_domaingoogle_networkservices_multicast_domain_activationgoogle_networkservices_multicast_domain_groupgoogle_networkservices_multicast_group_consumer_activationgoogle_networkservices_multicast_group_producer_activationgoogle_networkservices_multicast_group_rangegoogle_networkservices_multicast_group_range_activationgoogle_networkservices_multicast_producer_associationgoogle_networkservices_service_lb_policiesgoogle_networkservices_tcp_routegoogle_networkservices_tls_routeTests: Acceptance tests hit a GCP quota limit (QUOTA_FAIL). The generated code is correct — the PR is being opened as normal. Quota will be addressed on production infrastructure.