Skip to content

update urllib3 version #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharmaharisam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update urllib3 version #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"requests>=2.25.1",
"ruamel.yaml>=0.17.7",
"six>=1.15.0",
"urllib3>=1.26.2,<2",
"urllib3>=2",

@ghost ghost Dec 13, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing the upper bound allows flexibility, it's generally recommended to specify a version range to avoid potential issues with future, possibly incompatible urllib3 releases. Consider specifying an upper bound or a more precise version based on testing. For example, you could specify a compatible release or a range like urllib3>=2,<3, assuming major version 3 introduces breaking changes.

Suggested change
"urllib3>=2",
"urllib3>=2,<3"

@cnandigama1 cnandigama1 Feb 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharmaharisam Can this review comment be addressed to fix the issue raised #121

],
classifiers=[
"Programming Language :: Python :: 3",
Expand Down