Fix negative maxDepth in Jetty 12.1 fullScan hot-reload scanner#507
Merged
Conversation
ludoch
commented
Jun 10, 2026
ludoch
commented
Collaborator
- Resolves IllegalArgumentException on startup by setting scan depth to Integer.MAX_VALUE (which represents unlimited depth in Jetty 12.1) instead of the invalid negative -1 value.
- Applies the fix to both EE8 and EE11 configurations to ensure both support scanning deeply nested directories.
- Added e2e test (DevAppServerFullScanTest) that verifies the server boots without exceptions and successfully reloads when a nested resource file (> 3 levels deep) changes.
- Verified that on the original code, the EE8 server crashes on startup, and the EE11 server fails to trigger reloads for changes nested deeper than 3 directory levels.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Collaborator
Author
|
Fix for #506 |
- Resolves IllegalArgumentException on startup by setting scan depth to Integer.MAX_VALUE (which represents unlimited depth in Jetty 12.1) instead of the invalid negative -1 value. - Applies the fix to both EE8 and EE11 configurations to ensure both support scanning deeply nested directories. - Added e2e test (DevAppServerFullScanTest) that verifies the server boots without exceptions and successfully reloads when a nested resource file (> 3 levels deep) changes. - Verified that on the original code, the EE8 server crashes on startup, and the EE11 server fails to trigger reloads for changes nested deeper than 3 directory levels.
ludoch
force-pushed
the
fix-jetty-scan-depth
branch
from
da548d7 to
5d27b59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.