test(Spanner): Reverse: implement data type integration test for SQL Server

[pratickchokhani]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.66%. Comparing base (1576166) to head (4b250a8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##               main    #4243       +/-   ##
=============================================
+ Coverage     35.85%   63.66%   +27.81%     
- Complexity      713     2989     +2276     
=============================================
  Files           250      573      +323     
  Lines         17151    33656    +16505     
  Branches       1755     3795     +2040     
=============================================
+ Hits           6149    21427    +15278     
- Misses        10487    11150      +663     
- Partials        515     1079      +564     

Components	Coverage Δ
spanner-templates	84.47% <94.06%> (∅)
spanner-import-export	∅ <ø> (∅)
spanner-live-forward-migration	88.87% <98.14%> (∅)
spanner-live-reverse-replication	80.84% <94.06%> (∅)
spanner-bulk-migration	88.94% <98.14%> (∅)
gcs-spanner-dv	88.03% <98.14%> (∅)

Files with missing lines	Coverage Δ
...plates/source/sqlserver/SQLServerDMLGenerator.java	93.68% <100.00%> (ø)

... and 455 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive integration testing for SQL Server data type support in the Spanner-to-SourceDB migration template. It includes updates to the DML generator to ensure correct type mapping and adds infrastructure support for SQL Server in the integration test base.

Highlights

• Data Type Handling: Improved SQLServerDMLGenerator to correctly handle BYTES and PG_BYTEA types when mapping to NVARCHAR columns.
• Integration Testing: Added comprehensive integration tests for SQL Server data types, covering both standard and PostgreSQL dialect Spanner instances.
• Infrastructure: Updated SpannerToSourceDbITBase to include MSSQLResourceManager and helper methods for SQL Server schema management.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces SQL Server support to the Spanner-to-SourceDb pipeline, adding DML generation logic for byte types, mapping tests, and comprehensive integration tests for both GoogleSQL and PostgreSQL dialects. Feedback focuses on refactoring the newly added integration tests to eliminate nearly 95% code duplication through a shared base class, removing redundant synchronization in the static resource manager helper, changing static resource manager fields to instance fields to avoid shared state issues, and optimizing the row count validation by replacing a chain of 70+ condition checks with a single looped check.

[dhwanilpatel]

LGTM